feat: expose http object store #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesejo
force-pushed
the
feat/expose_http_object_store
branch
2 times, most recently
from
d3953b0 to
3f827d4
Compare
The objective is to allow the user to register CSV directly from an HTTP URL, delaying downloading the file until required
mesejo
force-pushed
the
feat/expose_http_object_store
branch
from
3f827d4 to
1d457f8
Compare
timsaucer
approved these changes
Oct 5, 2024
Comment on lines
22
to
-27
| from datafusion import SessionContext | ||
| from datafusion.object_store import LocalFileSystem | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def local(): | ||
| return LocalFileSystem() |
There was a problem hiding this comment.
This isn't blocking for this PR but it appears we have very little test coverage for object store. It's a bit tricky, though, since I'm not sure where there are publicly available test resources that we could use.
There was a problem hiding this comment.
Indeed, we need more test coverage. I'll try to find some files to test it
timsaucer
requested changes
Oct 6, 2024
mesejo
force-pushed
the
feat/expose_http_object_store
branch
from
0907a6e to
0724e9a
Compare
timsaucer
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Reading csv from HTTP directly
What changes are included in this PR?
The HTTP ObjectStore is exposed.
Are there any user-facing changes?
Yes