Skip to content

chore(bench): fix create_tables.sql for tpch benchmark #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore(bench): fix create_tables.sql for tpch benchmark #897

merged 1 commit into from
Oct 4, 2024

Conversation

@Michael-J-Ward
Copy link
Contributor

The WITH HEADER ROW and DELIMETER clauses are no longer in use, and upstream datafusion errors out with a message saying so.

WITH HEADER ROW clause is no longer in use. Please use the OPTIONS clause with 'format.has_header' set appropriately, e.g., OPTIONS (format.has_header true)

DELIMITER clause is no longer in use. Please use the OPTIONS clause with 'format.delimiter' set appropriately, e.g., OPTIONS (format.delimiter ',')

@Michael-J-Ward
chore(bench): fix create_tables.sql for tpch benchmark
60cff52 
The `WITH HEADER ROW` and `DELIMETER` clauses are no longer in use,
and upstream datafusion errors out with a message saying so.
timsaucer
timsaucer approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michael-J-Ward Michael-J-Ward merged commit 976b700 into apache:main Oct 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timsaucer timsaucer timsaucer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Michael-J-Ward @timsaucer