refactor: rename to with_column_renamed to rename
#908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
requested changes
Oct 13, 2024
Comment on lines
+183
to
+184
| def rename(self, mapping: dict[str, str]) -> DataFrame: | ||
| r"""Rename one or multiple columns by applying a new projection. |
There was a problem hiding this comment.
How about with_columns_renamed to be more clear what this is doing? I could imagine users confusing this changing a table's name, even though the dataframe doesn't have a name associated with it.
There was a problem hiding this comment.
I would argue rename is quite clear if you are acquainted with pandas and pola-rs API.
With columns renamed is quite verbose ^^
There was a problem hiding this comment.
I'd like to hear other people's opinions. Also I don't recommend we stray too far from what the upstream DataFusion uses for naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Simpler API that allows multiple renames instead of having to chain .with_column_renamed.
What changes are included in this PR?
with_column_renamed. I can look into adding a native rename in datafusion rust eventually.with_column_renamedAre there any user-facing changes?
with_column_renamed