Skip to content

Conversation

@kosiew
Copy link
Contributor

@kosiew kosiew commented Jan 13, 2025

Which issue does this PR close?

Closes #979.

Rationale for this change

Correct confusion of lz0 for lzo

What changes are included in this PR?

lz0 -> lzo

Are there any user-facing changes?

Yes.
lzo is not a valid compression method until it is implemented in arrow-rs.
apache/arrow-rs#6970

@kosiew kosiew marked this pull request as ready for review January 13, 2025 07:14
@kosiew
Copy link
Contributor Author

kosiew commented Jan 13, 2025

Encountered weird CI build error

Run ruff check --output-format=github python/
Would reformat: python/tests/test_functions.py
1 file would be reformatted, 35 files already formatted
Error: Process completed with exit code 1.

This PR does not include
python/tests/test_functions.py
at all.

Does anyone know how to solve this CI issue?

@kosiew
Copy link
Contributor Author

kosiew commented Jan 14, 2025

Encountered weird CI build error

Run ruff check --output-format=github python/
Would reformat: python/tests/test_functions.py
1 file would be reformatted, 35 files already formatted
Error: Process completed with exit code 1.

I reproduced this ruff error by changing my python venv from 3.10 to 3.12.

Then I ran
ruff format python/tests/test_functions.py

@timsaucer timsaucer merged commit 39fec53 into apache:main Jan 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lz0 should be lzo

3 participants