Add working CI tests to validate TPCH across a matrix of python / ray versions #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working CI tpch validation tests
Should fix #11, and maybe eliminates the need for #33.
Now, when the
mainbranch is pushed to, or a PR is opened against main, CI will run that will validate TPCH results at scale factor 1.This test will let us ensure that we do not stray from correct query execution as we iterate. This test also executes over a matrix of python versions,
3.10, 3.11, 3.12and ray versions2.40, 2.41, 2.42.1, 2.43, to ensure that combinations of these pass.A status indicator of whether the main branch passes tests is shown in the Readme.
Example execution of these tests can be seen in the fork: https://github.com/robtandy/datafusion-ray/actions/runs/13638548828
uvin addition topipuvfor CI makes sense as its so much faster. Turns out its good for local dev too. I updateddocs/contributing.mdto document the workflow borrowing much from thedatafusion-pythonreadme and its workflow.Other Small changes
--partitions-per-workerto--partitions-per-processorintpcbench.pytpcbench.py