resolve comments again

Author: byte-sourcerer

src/dialect/clickhouse.rs

@@ -50,4 +50,8 @@ impl Dialect for ClickHouseDialect {
     fn supports_limit_comma(&self) -> bool {
         true
     }
+
+    fn supports_table_function_in_insertion(&self) -> bool {
+        true
+    }
 }

src/dialect/mod.rs

@@ -780,6 +780,8 @@ pub trait Dialect: Debug + Any {
     ///
     /// MySQL: <https://dev.mysql.com/doc/refman/8.4/en/insert.html>
     fn supports_insert_set(&self) -> bool {
+    fn supports_table_function_in_insertion(&self) -> bool {
+    /// Does the dialect support table function in insertion?
         false
     }
 }

src/parser/mod.rs

@@ -8861,7 +8861,9 @@ impl<'a> Parser<'a> {
     /// Parse a table object for insetion
     /// e.g. `some_database.some_table` or `FUNCTION some_table_func(...)`
     pub fn parse_table_object(&mut self) -> Result<TableObject, ParserError> {
-        if dialect_of!(self is ClickHouseDialect) && self.parse_keyword(Keyword::FUNCTION) {
+        if self.dialect.supports_table_function_in_insertion()
+            && self.parse_keyword(Keyword::FUNCTION)
+        {
             let fn_name = self.parse_object_name(false)?;
             self.parse_function_call(fn_name)
                 .map(TableObject::TableFunction)

src/test_utils.rs

@@ -154,7 +154,6 @@ impl TestedDialects {
     pub fn one_statement_parses_to(&self, sql: &str, canonical: &str) -> Statement {
         let mut statements = self.parse_sql_statements(sql).expect(sql);
         assert_eq!(statements.len(), 1);
-        println!("sql: {}", sql);
         if !canonical.is_empty() && sql != canonical {
             assert_eq!(self.parse_sql_statements(canonical).unwrap(), statements);
         }