Skip to content

Conversation

git-hulk
Copy link
Member

@git-hulk
Copy link
Member Author

cc @iffyio

};
};

let on_cluster = self.parse_optional_on_cluster()?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ON CLUSTER is a ClickHouse-specific syntax, but we don't add the dialect guard for the sake of keeping consistent with other places.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10860941542

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 89.33%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 82.38%
Totals Coverage Status
Change from base Build 10817360923: 0.001%
Covered Lines: 29444
Relevant Lines: 32961

💛 - Coveralls

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU @iffyio and @git-hulk

@alamb alamb merged commit 1c505ce into apache:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants