Skip to content

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Oct 2, 2024

This closes #1452.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11144229831

Details

  • 35 of 40 (87.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 89.305%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 13 15 86.67%
tests/sqlparser_common.rs 17 20 85.0%
Totals Coverage Status
Change from base Build 11111316639: 0.002%
Covered Lines: 29960
Relevant Lines: 33548

💛 - Coveralls

@git-hulk
Copy link
Member Author

git-hulk commented Oct 2, 2024

cc @iffyio

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iffyio and @git-hulk

@alamb alamb merged commit 32a126b into apache:main Oct 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table comment is always parsed as CommentDef::WithoutEq

4 participants