Skip to content

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Oct 30, 2024

This adds the following features from the Microsoft SQL Server EXECUTE statement:

Support EXEC as an alias to EXECUTE
fixes #1275

Support schema qualified stored procedures
fixes #1276

support unnamed parameters in mssql EXECUTE stored procedure calls
fixes #1489

@alamb, I would love if we could get this merge, since this is blocking for sqlpage/SQLPage#655

This adds the following features from the Microsoft SQL Server EXECUTE statement:

Support EXEC as an alias to EXECUTE
fixes apache#1275

Support schema qualified stored procedures
fixes apache#1276

support unnamed parameters in mssql EXECUTE stored procedure calls
fixes apache#1489
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 2, 2024

@alamb , what do you think? Can we merge this like that?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-reviewed this PR -- and it looks good to me. Thank you @lovasoa

I agree with the generic thoughts from @iffyio about has_parenthesis and testing across all dialects, but I also agree there is no reason to gate merging this PR on those improvements

Thank you both as always

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11631184629

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 39 of 44 (88.64%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 89.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 6 8 75.0%
tests/sqlparser_common.rs 19 22 86.36%
Totals Coverage Status
Change from base Build 11580333290: -0.004%
Covered Lines: 30442
Relevant Lines: 34061

💛 - Coveralls

@alamb alamb merged commit d853c35 into apache:main Nov 7, 2024
10 checks passed
@lovasoa lovasoa deleted the mssql-execute branch November 7, 2024 16:06
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 7, 2024

Great, thank you @alamb and @iffyio ! The next version of SQLPage is going to be great with all these sqlparser improvements !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support parameters in mssql EXECUTE stored procedure calls Support schema qualified stored procedures for mssql Support mssql exec

4 participants