recursive select calls are parsed with bad trailing_commas parameter #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Nov 16, 2024
There was a problem hiding this comment.
Thanks @tomershaniii! Left some comments, I think the changes look reasonable overall
tomershaniii
force-pushed
the
main
branch
2 times, most recently
from
a93ba22 to
f5ec87b
Compare
|
Thanks for the review @iffyio, changes committed per your suggestions |
tomershaniii
force-pushed
the
main
branch
3 times, most recently
from
1d1547e to
2f70699
Compare
iffyio
reviewed
Nov 18, 2024
|
With tests fixed. @iffyio |
iffyio
reviewed
Nov 22, 2024
iffyio
approved these changes
Nov 23, 2024
alamb
approved these changes
Nov 23, 2024
|
|
||
| let ret = self.parse_comma_separated(|p| p.parse_select_item()); | ||
| self.options.trailing_commas = old_value; | ||
| let trailing_commas = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parse_projection function modifies the parsers 'options' flag, this creates different behavior when nesting select calls i.e. select(select()) which can manifest in failure to parse (see unit test)