Skip to content

support column type definitions in table aliases #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2024
Merged

support column type definitions in table aliases #1526

merged 4 commits into from
Nov 18, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Nov 15, 2024 

SELECT * FROM some_fun() AS x (a TEXT, b INT)

fixes #1524

@lovasoa
This adds support for
1be060f 
```sql
SELECT * FROM some_fun() AS x (a TEXT, b INT)
```

fixes apache#1524
@lovasoa
fix cargo doc
8494ce8
iffyio
iffyio reviewed Nov 16, 2024
View reviewed changes
iffyio
iffyio approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@alamb
Copy link
Contributor

alamb commented Nov 18, 2024

nice!

@alamb alamb merged commit f961efc into apache:main Nov 18, 2024
8 checks passed
@lovasoa lovasoa deleted the support_column_definition_list_in_table_alias branch November 18, 2024 14:20
@jqnatividad jqnatividad mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iffyio iffyio iffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support column definition list in table alias for postgres

3 participants

@lovasoa @alamb @iffyio