Skip to content

Allow example CLI to read from stdin #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Allow example CLI to read from stdin #1536

merged 1 commit into from
Nov 22, 2024

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Nov 20, 2024

No description provided.

iffyio
iffyio approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

alamb
alamb reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvzink and @iffyio

I tried it out

andrewlamb@Andrews-MacBook-Pro-2:~/Software/sqlparser-rs$ cargo run --example cli -

The only thing that was somewhat weird was I had to type Ctrl-D , but maybe we can treat ttys differently in the future

@alamb alamb merged commit a115022 into apache:main Nov 22, 2024
8 checks passed
@mvzink mvzink deleted the cli-stdin branch December 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb left review comments

@iffyio iffyio iffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvzink @alamb @iffyio