Skip to content

Add support for USE SECONDARY ROLE (vs. ROLES) #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Add support for USE SECONDARY ROLE (vs. ROLES) #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10529,7 +10529,7 @@ impl<'a> Parser<'a> {
}

fn parse_secondary_roles(&mut self) -> Result<Use, ParserError> {
self.expect_keyword_is(Keyword::ROLES)?;
self.expect_one_of_keywords(&[Keyword::ROLES, Keyword::ROLE])?;
if self.parse_keyword(Keyword::NONE) {
Ok(Use::SecondaryRoles(SecondaryRoles::None))
} else if self.parse_keyword(Keyword::ALL) {
Expand Down
8 changes: 8 additions & 0 deletions tests/sqlparser_snowflake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2782,6 +2782,14 @@ fn parse_use() {
snowflake().verified_stmt("USE SECONDARY ROLES ALL");
snowflake().verified_stmt("USE SECONDARY ROLES NONE");
snowflake().verified_stmt("USE SECONDARY ROLES r1, r2, r3");

// The following is not documented by Snowflake but still works:
snowflake().one_statement_parses_to("USE SECONDARY ROLE ALL", "USE SECONDARY ROLES ALL");
snowflake().one_statement_parses_to("USE SECONDARY ROLE NONE", "USE SECONDARY ROLES NONE");
snowflake().one_statement_parses_to(
"USE SECONDARY ROLE r1, r2, r3",
"USE SECONDARY ROLES r1, r2, r3",
);
}

#[test]
Expand Down
Loading