Add supports for Hive's SELECT ... GROUP BY .. GROUPING SETS syntax
#1653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jan 16, 2025
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
wugeer
force-pushed
the
feat/add_support_enhance_agg_func
branch
from
b08cdfd to
2d26599
Compare
…ts for Clickhouse's `GROUP BY GROUPING SETS` syntax
iffyio
reviewed
Feb 9, 2025
more doc Co-authored-by: Ifeanyi Ubah <[email protected]>
…/sqlparser-rs into feat/add_support_enhance_agg_func
|
@iffyio Thank you for your guidance! I have resubmitted the code and hope to receive your review again. :) |
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
…apache#1653) Co-authored-by: Ifeanyi Ubah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
SELECT ... GROUP BY .. GROUPING SETSsyntax for hive dialect. For more information, please refer to:https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C+Grouping+and+Rollup#EnhancedAggregation,Cube,GroupingandRollup-GROUPINGSETSclause
Also support hive
with rollup/cubeclause.This resolves issue #1644