Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 20, 2025

When I tried to create the release tarball this time I got an error:

Running rat license checker on /Users/andrewlamb/Software/sqlparser-rs/dev/dist/apache-datafusion-sqlparser-rs-0.54.0-rc1/apache-datafusion-sqlparser-rs-0.54.0.tar.gz
NOT APPROVED: sqlparser_bench/img/flamegraph.svg (apache-datafusion-sqlparser-rs-0.54.0/sqlparser_bench/img/flamegraph.svg): false
       1 unapproved licences. Check rat report: rat.txt

I think this is because svg files are XML so the rat checker checks them for the apache license

There is no reason to add the license explicitly I don't think so I propose adding to the exclude file

I was able to use this change locally to make the 0.54.0 RC so there is no particular urgency for this PR

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iffyio iffyio merged commit e5bc3df into apache:main Jan 20, 2025
18 checks passed
@alamb alamb deleted the alamb/fix_rat branch January 20, 2025 22:48
@alamb
Copy link
Contributor Author

alamb commented Jan 20, 2025

Thanks @iffyio

hansott added a commit to hansott/datafusion-sqlparser-rs that referenced this pull request Jan 23, 2025
…o escape-literals

* 'main' of github.com:hansott/datafusion-sqlparser-rs:
  National strings: check if dialect supports backslash escape (apache#1672)
  Add support for Create Iceberg Table statement for Snowflake parser (apache#1664)
  Add support for Snowflake account privileges (apache#1666)
  Update rat_exclude_file.txt (apache#1670)
  Update verson to 0.54.0 and update changelog (apache#1668)
  Add support for Snowflake AT/BEFORE (apache#1667)
  Add support for qualified column names in JOIN ... USING (apache#1663)
  Add support for `IS [NOT] [form] NORMALIZED` (apache#1655)
  fix parsing of `INSERT INTO ... SELECT ... RETURNING ` (apache#1661)
  Add support for Snowflake column aliases that use SQL keywords (apache#1632)
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Vedin added a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants