Skip to content

National strings: check if dialect supports backslash escape #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2025
Merged

National strings: check if dialect supports backslash escape #1672

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10f8224
National strings: check if dialect supports backslash escape
hansott Jan 21, 2025
78c4580
Format code
hansott Jan 21, 2025
da2ce86
Use `all_dialects_where` to test backslash escape for every dialect
hansott Jan 23, 2025
761f509
Format code
hansott Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/tokenizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,10 @@ impl<'a> Tokenizer<'a> {
match chars.peek() {
Some('\'') => {
// N'...' - a <national character string literal>
let s = self.tokenize_single_quoted_string(chars, '\'', true)?;
let backslash_escape =
self.dialect.supports_string_literal_backslash_escape();
let s =
self.tokenize_single_quoted_string(chars, '\'', backslash_escape)?;
Ok(Some(Token::NationalStringLiteral(s)))
}
_ => {
Expand Down Expand Up @@ -3543,4 +3546,17 @@ mod tests {
];
compare(expected, tokens);
}

#[test]
fn test_national_strings() {
let dialect = PostgreSqlDialect {};
let sql = "select n'''''\\'";
let tokens = Tokenizer::new(&dialect, sql).tokenize().unwrap();
let expected = vec![
Token::make_keyword("select"),
Token::Whitespace(Whitespace::Space),
Token::NationalStringLiteral("''\\".to_string()),
];
compare(expected, tokens);
}
}
Loading