Skip to content

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Feb 4, 2025

No description provided.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvzink!

@alamb alamb marked this pull request as draft February 7, 2025 18:09
@alamb
Copy link
Contributor

alamb commented Feb 7, 2025

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look

@mvzink mvzink marked this pull request as ready for review February 7, 2025 22:56
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @mvzink

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!

@iffyio iffyio merged commit cad4923 into apache:main Feb 8, 2025
9 checks passed
@mvzink mvzink deleted the parse-varbit branch February 10, 2025 16:23
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants