Skip to content

Conversation

assignUser
Copy link
Member

The actions-rs org has been archived for years at this point and it doesn't look like it's coming back. For security reasons we are going to remove it from the allow list soon.

In this PR I have replaced the usage of actions-rs/install with a well known rust cache action and a normal cargo install

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @assignUser!
cc @alamb

uses: ./.github/actions/setup-builder
with:
rust-version: ${{ matrix.rust }}
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that we use the same action in DataFusion so this sounds like a good idea to me 👍

https://github.com/apache/datafusion/blob/b41acf3c43ff259a22f9ecc2abdb17db58297fd8/.github/actions/setup-macos-aarch64-builder/action.yaml#L47

Thanks @assignUser and @iffyio

@alamb alamb merged commit 9fc9009 into apache:main Jun 10, 2025
9 checks passed
@assignUser assignUser deleted the replace-actions-rs branch June 11, 2025 07:51
solontsev pushed a commit to solontsev/datafusion-sqlparser-rs that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants