Fix parsing error when having fields after nested struct in BigQuery #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iffyio Could you please take a look at this fix? The root cause is that it might have more field definitions after the trailing bracket, but now always regarded as an unmatched bracket condition. The code block is somewhat complex to fix due to its recursive behavior, but I have added more cases for it, and it works well. |
Before applying this patch, the following SQL cannot be parsed: ```SQL CREATE TABLE my_table ( f0 STRING, f1 STRUCT<a STRING, b STRUCT<c INT64, d STRING>>, f2 STRING, ) ``` But it's a valid SQL in BigQuery. The root cause is having comma after the trailing bracket will be reconigized as a mismatched closing.
git-hulk
force-pushed
the
fix/error-in-trailling-bracket
branch
from
758c307 to
b66a377
Compare
iffyio
reviewed
Jun 20, 2025
tests/sqlparser_bigquery.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_struct_trailing_bracket() { |
There was a problem hiding this comment.
Could we merge this test with this one? since they're covering the same behavior. I imagine we could just move the test cases in the latter function into this new function and should be good?
There was a problem hiding this comment.
@iffyio Thanks for your suggestion. I didn't notice that test case, and have moved it into a dedicated one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before applying this patch, the following SQL cannot be parsed:
But it's a valid SQL in BigQuery. The root cause is that having a comma after the trailing bracket will be recognized as a mismatched closing bracket.