Skip to content

Conversation

ZacJW
Copy link
Contributor

@ZacJW ZacJW commented Jun 22, 2025

Currently there's no support for argmodes (IN, OUT, INOUT) in CREATE PROCEDURE statements despite the standard (I'm reading a BNF for ISO/IEC 9075-2:2003 since I don't have anything newer) and 'RDBMS's like MySQL and PostgreSQL supporting them.

This PR adds support for the standard modes (PostgreSQL's VARIADIC mode is not supported).

@ZacJW
Copy link
Contributor Author

ZacJW commented Jun 22, 2025

Just found the link to https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html in the README, and this implementation is still valid.

@ZacJW ZacJW marked this pull request as ready for review June 22, 2025 11:07
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ZacJW!
cc @alamb

@iffyio iffyio merged commit b9365b3 into apache:main Jun 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants