Fix join precedence for non-snowflake queries #1905
Merged
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jun 28, 2025
src/parser/mod.rs
Outdated
| let mut relation = self.parse_table_factor()?; | ||
|
|
||
| if self.peek_parens_less_nested_join() { | ||
| if dialect_of!(self is SnowflakeDialect) && self.peek_parens_less_nested_join() { |
There was a problem hiding this comment.
Can we change this to a dialect method that is only set to true for snowflake? e.g. if self.dialect.supports_parens_less_nested_join() && self.peek_parens_less_nested_join()
tests/sqlparser_common.rs
Outdated
|
|
||
| #[test] | ||
| fn join_precedence() { | ||
| all_dialects_except(|d| d.is::<SnowflakeDialect>()).verified_query_with_canonical( |
There was a problem hiding this comment.
By switching to the dialect method, we would be able to change these to use all_dialects_where(|d|d.supports_parens_less_nested_join())
|
Thanks for the review, @iffyio - I've addressed your feedback and it’s ready for another round when you are. |
iffyio
approved these changes
Jun 28, 2025
| false | ||
| } | ||
|
|
||
| /// Indicates whether the dialect supports left-associative join parsing |
There was a problem hiding this comment.
Very nice thanks for the description!
Dimchikkk
added a commit
to Dimchikkk/datafusion-sqlparser-rs
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1904.
The bug was introduced in #1799.