Skip to content

Conversation

solontsev
Copy link
Contributor

Closes #1814

@solontsev solontsev marked this pull request as ready for review June 30, 2025 05:23
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @solontsev! Could you look to merge in the latest from main to resolve the conflicts on the branch. Beyond that I think this looks good to me!

# Conflicts:
#	tests/sqlparser_postgres.rs
@solontsev
Copy link
Contributor Author

Thanks @iffyio! Done

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @solontsev!
cc @alamb

@iffyio iffyio changed the title Support for Postgres's CREATE SERVER Support for Postgres CREATE SERVER Jul 3, 2025
@iffyio iffyio merged commit 239e30a into apache:main Jul 3, 2025
10 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 3, 2025

THank you @iffyio for being a coding machine -- it is pretty amazing to see all this code go in -- its like we don't really have any idea how many crazy variants of SQL there are until you see the steady stream of PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Postgres CREATE SERVER can't be parsed

3 participants