-
Notifications
You must be signed in to change notification settings - Fork 670
Support for Postgres CREATE SERVER
#1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Ifeanyi Ubah <[email protected]>
Co-authored-by: Ifeanyi Ubah <[email protected]>
Co-authored-by: Ifeanyi Ubah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @solontsev! Could you look to merge in the latest from main to resolve the conflicts on the branch. Beyond that I think this looks good to me!
# Conflicts: # tests/sqlparser_postgres.rs
Thanks @iffyio! Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @solontsev!
cc @alamb
CREATE SERVER
THank you @iffyio for being a coding machine -- it is pretty amazing to see all this code go in -- its like we don't really have any idea how many crazy variants of SQL there are until you see the steady stream of PRs |
Closes #1814