Align Snowflake dialect to new test of reserved keywords #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered a problem parsing statements like
SELECT 1, sort FROM tblwhich are valid in Snowflake.The reason is that in the Snowflake dialect, supports_projection_trailing_commas is
true. The flow then checks the keyword after the comma to see if it's reserved (FROMfor example), and if not, it stops parsing the projection. However, the check relies onDialect::is_column_aliaswhich wasn't implemented in the Snowflake dialog.The solution is to align the behavior of the Snowflake dialect to other dialects by overriding
Dialect::is_column_aliasinstead ofDialect::is_select_item_alias.