Skip to content

Conversation

solontsev
Copy link
Contributor

Closes #1853

@solontsev
Copy link
Contributor Author

I made it more permissive by allowing empty parentheses. I'd appreciate your feedback on this

@solontsev solontsev marked this pull request as ready for review July 5, 2025 04:46
@iffyio iffyio changed the title Support for ClickHouse CREATE TABLE .... Engine = MergeTree() Clickhouse: support empty parenthesized options Jul 6, 2025
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @solontsev!
cc @alamb

@iffyio iffyio merged commit 1a33abd into apache:main Jul 6, 2025
10 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 7, 2025

Thanks as always for keeping the code flowing @iffyio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clickhouse CREATE TABLE .... Engine = MergeTree() should be supported

3 participants