Snowflake Reserved SQL Keywords as Implicit Table Alias #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavcloud
changed the title
iffyio
reviewed
Jul 10, 2025
There was a problem hiding this comment.
Thanks @yoavcloud! Just a minor comment re peeking otherwise this looks good to me
src/dialect/snowflake.rs
Outdated
| if parser.peek_keyword(Keyword::FIRST) | ||
| || parser.peek_keyword(Keyword::NEXT) |
There was a problem hiding this comment.
Suggested change
| if parser.peek_keyword(Keyword::FIRST) | |
| || parser.peek_keyword(Keyword::NEXT) | |
| if parser.peek_one_of_keyword(&[Keyword::FIRST, Keyword::NEXT]) |
I think this would be equivalent and simplify?
yoavcloud
force-pushed
the
sd_reserverd_kws_tables_alias
branch
from
e48fe75 to
cdfd75f
Compare
iffyio
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same pattern of
Dialect::is_select_item_aliasfor table aliases. Added handling for Snowflake-specific keywords when used as an implicit table alias (i.e. withoutAS).