Add support for Redshift SELECT * EXCLUDE
#1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 10, 2025
| _ => unreachable!(), | ||
| } | ||
|
|
||
| let dialects = all_dialects_where(|d| d.supports_select_exclude()); |
There was a problem hiding this comment.
Could we add a test with
let dialects = all_dialects_where(|d| d.supports_select_wildcard_exclude() && !d.supports_select_exclude());like in snowflake's case to demonstrate the behavior when there is e.g. an exclude that is an ident SELECT *, EXCLUDE c1 FROM test or similar
yoavcloud
force-pushed
the
redshift_select_exclude
branch
from
9da1b35 to
85a8ea4
Compare
iffyio
approved these changes
Jul 11, 2025
iffyio
changed the title
SELECT * EXCLUDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redshift supports placing the
EXCLUDEoption at the end of the projection list, not necessarily after the wildcard. For example:SELECT *, c1 EXCLUDE c2 FROM test(exclude column c2 from the list of all columns including c1).Added support for parsing this option by reusing the existing
ExcludeSelectItemstruct but placing it at the query level, after the projection.