Snowflake: Improve accuracy of lookahead in implicit LIMIT alias #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 14, 2025
src/dialect/snowflake.rs
Outdated
| Keyword::LIMIT | ||
| if matches!( | ||
| parser.peek_token().token, | ||
| Token::Number(_, _) | Token::Placeholder(_) |
There was a problem hiding this comment.
from their docs they seem to mention that null and empty string, $ values are possible, could we also detect for those here?
There was a problem hiding this comment.
Thanks for the great feedback! The latest commit introduces a more accurate lookahead logic.
yoavcloud
force-pushed
the
sf_limit_lookahead
branch
from
6e08364 to
7240269
Compare
iffyio
approved these changes
Jul 17, 2025
|
It is pretty epic that this code keeps rolling along |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some needed adjustments to the lookahead logic when considering the
LIMITkeyword as an implicit table alias.