Skip to content

Conversation

yoavcloud
Copy link
Contributor

Add support for the MySQLFORMAT=<FORMAT TYPE> syntax for EXPLAIN ANALYZE

Comment on lines 7647 to 7652
pub enum AnalyzeFormatKind {
Keyword(AnalyzeFormat),
Assignment(AnalyzeFormat),
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some description ideally with example syntax to show the difference between each variant? Thinking that might not be obvious otherwise to someone looking at the API

@yoavcloud yoavcloud force-pushed the mysql_explain_format branch from d7cbbf2 to 8701bc4 Compare July 17, 2025 12:22
@yoavcloud yoavcloud requested a review from iffyio July 17, 2025 12:23
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yoavcloud!
cc @alamb

@iffyio iffyio changed the title MySQL: EXPLAIN ANALYZE format type MySQL: Support EXPLAIN ANALYZE format variants Jul 18, 2025
@iffyio iffyio merged commit 23f40cd into apache:main Jul 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants