fix: begin statement for bigquery #1975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 24, 2025
tests/sqlparser_bigquery.rs
Outdated
| ); | ||
| } | ||
|
|
||
| // https://cloud.google.com/bigquery/docs/reference/standard-sql/procedural-language#begin_transaction |
There was a problem hiding this comment.
Suggested change
| // https://cloud.google.com/bigquery/docs/reference/standard-sql/procedural-language#begin_transaction |
src/dialect/bigquery.rs
Outdated
Comment on lines
51
to
59
| if parser.peek_keyword(Keyword::TRANSACTION) { | ||
| parser.prev_token(); | ||
| return None; | ||
| } | ||
| let peek_token = parser.peek_token_ref(); | ||
| if peek_token.token == Token::SemiColon || peek_token.token == Token::EOF { | ||
| parser.prev_token(); | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Can we merge both blocks with something like if parse.parse_keyword(BEGIN) || peek_token.token == SemiColon || peek_token.token == EOF
iffyio
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
big query supports,
but currently parse_statement is overwritten for bigquery, and this statement is not supported.