Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ast/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3238,6 +3238,8 @@ pub enum Statement {
returning: Option<Vec<SelectItem>>,
/// SQLite-specific conflict resolution clause
or: Option<SqliteOnConflict>,
/// LIMIT
limit: Option<Expr>,
},
/// ```sql
/// DELETE
Expand Down Expand Up @@ -4810,6 +4812,7 @@ impl fmt::Display for Statement {
selection,
returning,
or,
limit,
} => {
f.write_str("UPDATE ")?;
if let Some(or) = or {
Expand Down Expand Up @@ -4843,6 +4846,10 @@ impl fmt::Display for Statement {
f.write_str("RETURNING")?;
indented_list(f, returning)?;
}
if let Some(limit) = limit {
SpaceOrNewline.fmt(f)?;
write!(f, "LIMIT {limit}")?;
}
Ok(())
}
Statement::Delete(delete) => delete.fmt(f),
Expand Down
1 change: 1 addition & 0 deletions src/ast/spans.rs
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ impl Spanned for Statement {
selection,
returning,
or: _,
limit: _,
} => union_spans(
core::iter::once(table.span())
.chain(assignments.iter().map(|i| i.span()))
Expand Down
6 changes: 6 additions & 0 deletions src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15152,13 +15152,19 @@ impl<'a> Parser<'a> {
} else {
None
};
let limit = if self.parse_keyword(Keyword::LIMIT) {
Some(self.parse_expr()?)
} else {
None
};
Ok(Statement::Update {
table,
assignments,
from,
selection,
returning,
or,
limit,
})
}

Expand Down
2 changes: 2 additions & 0 deletions tests/sqlparser_common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ fn parse_update_set_from() {
}),
returning: None,
or: None,
limit: None
}
);

Expand All @@ -533,6 +534,7 @@ fn parse_update_with_table_alias() {
selection,
returning,
or: None,
limit: None,
} => {
assert_eq!(
TableWithJoins {
Expand Down
1 change: 1 addition & 0 deletions tests/sqlparser_mysql.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2516,6 +2516,7 @@ fn parse_update_with_joins() {
selection,
returning,
or: None,
limit: None,
} => {
assert_eq!(
TableWithJoins {
Expand Down
20 changes: 19 additions & 1 deletion tests/sqlparser_sqlite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,8 @@ fn parse_update_tuple_row_values() {
joins: vec![],
},
from: None,
returning: None
returning: None,
limit: None
}
);
}
Expand Down Expand Up @@ -592,6 +593,23 @@ fn test_regexp_operator() {
sqlite().verified_only_select(r#"SELECT count(*) FROM messages WHERE msg_text REGEXP '\d+'"#);
}

#[test]
fn test_update_delete_limit() {
match sqlite().verified_stmt("UPDATE foo SET bar = 1 LIMIT 99") {
Statement::Update { limit, .. } => {
assert_eq!(limit, Some(Expr::value(number("99"))));
}
_ => unreachable!(),
}

match sqlite().verified_stmt("DELETE FROM foo LIMIT 99") {
Statement::Delete(Delete { limit, .. }) => {
assert_eq!(limit, Some(Expr::value(number("99"))));
}
_ => unreachable!(),
}
}

fn sqlite() -> TestedDialects {
TestedDialects::new(vec![Box::new(SQLiteDialect {})])
}
Expand Down