feat: Include end token in ALTER TABLE statement
#1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about the linting violations, I addressed one, but it seemed unrelated to the change. |
iffyio
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Thanks @IndexSeek! Changes look good to me overall, left some minor comments.
The lint failure has been fixed on the latest main so that merging in from main should resolve the failure in this branch
IndexSeek
force-pushed
the
incorrect-line-ending-spans
branch
from
3cba41e to
9a42c3f
Compare
Co-authored-by: Ifeanyi Ubah <[email protected]>
iffyio
changed the title
ALTER TABLE statement
iffyio
approved these changes
Aug 9, 2025
|
Thanks! I can confirm this solved #1858. Are there any estimates on the next release? |
This is the next scheduled release We mostly do releases on a schedule, but feel free to discss on that ticket if you would like to request an earlier release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1858 in span calculation for
ALTER TABLEstatements. The span forALTER TABLEstatements was ending too early and not including the semicolon.