Skip to content

Conversation

MohamedAbdeen21
Copy link
Contributor

Adds support for MySQL's deprecated UNSIGNED keyword syntax for some numeric types. This includes:

  • DECIMAL UNSIGNED, DEC UNSIGNED
  • FLOAT UNSIGNED
  • DOUBLE UNSIGNED
  • REAL UNSIGNED, DOUBLE PRECISION UNSIGNED

Also, allow FLOAT to accept precision and scale, not just precision.

docs: https://dev.mysql.com/doc/refman/8.4/en/numeric-type-syntax.html

…types

Adds support for MySQL's deprecated UNSIGNED keyword syntax for
some numeric types. This includes:
- DECIMAL UNSIGNED, DEC UNSIGNED
- FLOAT UNSIGNED
- DOUBLE UNSIGNED
- REAL UNSIGNED, DOUBLE PRECISION UNSIGNED

Also, allow FLOAT to accept precision and scale, not just precision.

docs: https://dev.mysql.com/doc/refman/8.4/en/numeric-type-syntax.html
Copy link
Contributor

@mvzink mvzink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me; only thing I might suggest is checking how these types behave (or don't) in the context of CAST.

@iffyio iffyio changed the title MySQL deprecated unsigned numeric types MySQL: Add support for unsigned numeric types Sep 19, 2025
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MohamedAbdeen21!

@iffyio iffyio added this pull request to the merge queue Sep 19, 2025
Merged via the queue into apache:main with commit ea7f902 Sep 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants