Moving several struct variants out of Statement enum to allow for trait impls for specific sub-variants
#2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaCappelletti94
changed the title
Statement enum to allow for trait impls for specific sub-variantsStatement enum to allow for trait impls for specific sub-variants
iffyio
approved these changes
Oct 10, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
Contributor
|
@LucaCappelletti94 could you take a look at resolving the conflicts when you get the chance? |
Contributor
Author
Yeah, let's first wrap up also the sqlite trigger and then I will handle all of the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, in this PR I moved several of the struct variants out of the
Statementenum. This refactoring allows for implementing traits and methods which specifically expect one particular statement, and not all of them.I have focused on the variants which I am familiar with, primarily those related to PostgreSQL. There are still other struct variant which we might want to move out, such as
Drop, but that variant would need to be renamed into some other naming convention because of the collision with theDroptrait.This PR works towards solving issues such as #1204
Best,
Luca