fix: qualified column names with SQL keywords parse as identifiers #2157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v0.55.0, qualified column names using SQL keywords failed to parse. For example, `T.interval` in `PARTITION BY T.key, T.interval ORDER BY ...` was incorrectly interpreted as an INTERVAL expression instead of a column. In `3e90a18` changed `parse_compound_expr` to use `parse_subexpr()` for tokens after `.`, causing keywords like INTERVAL, CASE, CAST, etc. to be treated as expression starters. Explicitly handle `Token::Word` in `parse_compound_expr` by treating it as an identifier. If followed by `(` (excluding the `(+)` outer join operator), parse as a method call. This restores the original behavior where words after `.` were always converted to identifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.55.0, qualified column names using SQL keywords failed to parse. For example,
T.intervalinPARTITION BY T.key, T.interval ORDER BY ...was incorrectly interpreted as an INTERVAL expression instead of a column.In
3e90a18changedparse_compound_exprto useparse_subexpr()for tokens after., causing keywords like INTERVAL, CASE, CAST, etc. to be treated as expression starters.Explicitly handle
Token::Wordinparse_compound_exprby treating it as an identifier. If followed by((excluding the(+)outer join operator), parse as a method call. This restores the original behavior where words after.were always converted to identifiers.