wip

Author: Dandandan

datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/accumulate.rs

@@ -110,7 +110,7 @@ impl NullState {
         T: ArrowPrimitiveType + Send,
         F: FnMut(usize, T::Native) + Send,
     {
-        if self.all_seen() == 0 && opt_filter.is_none() && values.null_count() == 0 {
+        if self.all_seen() && opt_filter.is_none() && values.null_count() == 0 {
             accumulate(group_indices, values, None, value_fn);
             self.seen_values_size = total_num_groups;
         } else {
@@ -155,7 +155,7 @@ impl NullState {
         let data = values.values();
         assert_eq!(data.len(), group_indices.len());
 
-        if self.all_seen() == 0 && opt_filter.is_none() && values.null_count() == 0 {
+        if self.all_seen() && opt_filter.is_none() && values.null_count() == 0 {
             group_indices
                 .iter()
                 .zip(data.iter())
@@ -272,7 +272,7 @@ impl NullState {
 
     /// Returns true if all groups have seen at least one non null
     fn all_seen(&self) -> bool {
-        self.seen_values.capacity() == 0
+        self.seen_values.len() == 0
     }
 }