-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Unparse struct to sql #13493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Unparse struct to sql #13493
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
626e2dd
unparse struct to sql
delamarch3 378679e
add roundtrip statement test for named_struct
delamarch3 4e83eb3
quote keys if needed
delamarch3 bd4d71d
add roundtrip statement test for get_field
delamarch3 6222885
improve error messages
delamarch3 ef4209a
fmt
delamarch3 9c3ba00
fmt
delamarch3 a8dd310
match string literals only
delamarch3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider the more complex cases, a struct contains a struct field. Consider the following SQL that uses another way to access the struct:
You can see the
get_field
accepts anotherget_field
function. However, I think we can't do a roundtrip test for this kind of case currently because SQL likeselect s.a.a1
isn't supported (apache/datafusion-sqlparser-rs#1541 will address it).By the way, I think we can file a follow-up issue for the nested case. We don't need to support it in this PR.