Skip to content

ci improvements, update protoc #13876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 26, 2024
Merged

ci improvements, update protoc #13876

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a18c82f
Fix md5 return_type to only return Utf8 as per current code impl.
Omega359 Nov 15, 2024
ad50ae6
Merge remote-tracking branch 'origin/main'
Omega359 Nov 21, 2024
1e87f7e
Merge remote-tracking branch 'origin/main'
Omega359 Nov 28, 2024
cc1f540
Merge remote-tracking branch 'origin/main'
Omega359 Dec 3, 2024
a733c8f
Merge remote-tracking branch 'origin/main'
Omega359 Dec 16, 2024
87b388e
Merge remote-tracking branch 'origin/main'
Omega359 Dec 21, 2024
b6a95d9
ci improvements
Omega359 Dec 21, 2024
9b8b8f6
Lock taiki-e/install-action to a githash for apache action policy - R…
Omega359 Dec 21, 2024
b827048
Lock taiki-e/install-action to a githash for apache action policy - R…
Omega359 Dec 21, 2024
d47d535
Revert nextest change until action is approved.
Omega359 Dec 21, 2024
be7e273
Exclude requires workspace
Omega359 Dec 22, 2024
62230f8
Fixing minor typo to verify ci caching of builds is working as expected.
Omega359 Dec 22, 2024
7579841
Merge remote-tracking branch 'origin/main' into feature/ci_improvements
Omega359 Dec 24, 2024
03509ba
Updates from PR review.
Omega359 Dec 24, 2024
b9e8ecd
Adding issue link for disabling intel mac build
Omega359 Dec 24, 2024
64c7d4b
improve performance of running examples
Omega359 Dec 25, 2024
8d21ec1
remove cargo check
Omega359 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/setup-builder/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ runs:
"${RETRY[@]}" rustup component add rustfmt
- name: Configure rust runtime env
uses: ./.github/actions/setup-rust-runtime
- name: Setup Rust cache
uses: Swatinem/rust-cache@v2
- name: Fixup git permissions
# https://github.com/actions/checkout/issues/766
shell: bash
Expand Down
6 changes: 4 additions & 2 deletions .github/actions/setup-macos-aarch64-builder/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ runs:
run: |
mkdir -p $HOME/d/protoc
cd $HOME/d/protoc
export PROTO_ZIP="protoc-21.4-osx-aarch_64.zip"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
export PROTO_ZIP="protoc-29.1-osx-aarch_64.zip"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v29.1/$PROTO_ZIP
unzip $PROTO_ZIP
echo "$HOME/d/protoc/bin" >> $GITHUB_PATH
export PATH=$PATH:$HOME/d/protoc/bin
Expand All @@ -43,5 +43,7 @@ runs:
rustup toolchain install stable
rustup default stable
rustup component add rustfmt
- name: Setup rust cache
uses: Swatinem/rust-cache@v2
- name: Configure rust runtime env
uses: ./.github/actions/setup-rust-runtime
4 changes: 2 additions & 2 deletions .github/actions/setup-macos-builder/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ runs:
run: |
mkdir -p $HOME/d/protoc
cd $HOME/d/protoc
export PROTO_ZIP="protoc-21.4-osx-x86_64.zip"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
export PROTO_ZIP="protoc-29.1-osx-x86_64.zip"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v29.1/$PROTO_ZIP
unzip $PROTO_ZIP
echo "$HOME/d/protoc/bin" >> $GITHUB_PATH
export PATH=$PATH:$HOME/d/protoc/bin
Expand Down
1 change: 1 addition & 0 deletions .github/actions/setup-rust-runtime/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ runs:
echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV
echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
echo "CARGO_INCREMENTAL=false" >> $GITHUB_ENV
Copy link
Contributor

@alamb alamb Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this may be redundant with the line below (or if the line below isn't working. perhaps we could remove it 🤔 )

Copy link
Contributor Author

@Omega359 Omega359 Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. I wasn't sure at one point so I put it there to test.

echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false" >> $GITHUB_ENV

4 changes: 2 additions & 2 deletions .github/actions/setup-windows-builder/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ runs:
run: |
mkdir -p $HOME/d/protoc
cd $HOME/d/protoc
export PROTO_ZIP="protoc-21.4-win64.zip"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
export PROTO_ZIP="protoc-29.1-win64.zip"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v29.1/$PROTO_ZIP
unzip $PROTO_ZIP
export PATH=$PATH:$HOME/d/protoc/bin
protoc.exe --version
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
fetch-depth: 1
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/docs_pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
fetch-depth: 1
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
Expand Down
Loading
Loading