Add TableProvider::insert_into into FFI Bindings#14391
Conversation
This method was missing from the FFI bindings for use in datafusion-python extensions.
|
@timsaucer Apparently I can't request my own reviewers, but I figured you'd want a heads up on this. |
alamb
changed the title
TableProvider::insert_into into FFI Bindings
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @davisp this looks good to me
As we are about to do a release for 45 I plan to merge this shortly to get it into the release. FYI @timsaucer
|
I merged up from main to make sure CI is running on the latest commit. Once tests pass I plan to merge |
|
The CI failure https://github.com/apache/datafusion/actions/runs/13088375990/job/36522221854?pr=14391 Seems to be due to a logical conflict with I am investigating |
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
Thank you! This looks like a very clean addition and includes unit tests.
|
I have to go do something else now -- @timsaucer any chance you can figure out the CI failure? |
Yes, I can do this right now |
… of the current async function to the foreign execution plan on the insert_into operation
|
Woohoo! 🚀 |
|
Thanks @davisp and @timsaucer |
* Wrap TableProvider::insert_into This method was missing from the FFI bindings for use in datafusion-python extensions. * Switch from passing the runtime around to it's handle, add the handle of the current async function to the foreign execution plan on the insert_into operation --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Tim Saucer <timsaucer@gmail.com>
3 participants
This method was missing from the FFI bindings for use in datafusion-python extensions.
Which issue does this PR close?
Closes #14390.
Rationale for this change
Add missing method wrapper for
TableProvider::insert_intoin the FFI bindings.What changes are included in this PR?
A wrapper for
TableProvider::insert_intois added.Are these changes tested?
Its tested as thoroughly as
TableProvider::scan.Are there any user-facing changes?
Previously wrapped
TableProviderinstances will now supportinsert_intowhich I guess would be user-facing?