Remove unused crate dependencies#14827
Merged
xudong963 merged 3 commits intoapache:mainfrom Feb 23, 2025
Merged
Conversation
Allow contributors to run extended tests workflow if they wish to, just like they can run rust tests workflow on their forks, before opening a PR to DataFusion. GitHub allows enabling/disabling workflows in the web UI without needing to change workflow yaml file.
Found by `cargo udeps`. Unfortunately there were false positives too.
ozankabak
pushed a commit
to synnada-ai/datafusion-upstream
that referenced
this pull request
Feb 25, 2025
* Enable 'extended tests' on forks Allow contributors to run extended tests workflow if they wish to, just like they can run rust tests workflow on their forks, before opening a PR to DataFusion. GitHub allows enabling/disabling workflows in the web UI without needing to change workflow yaml file. * Remove unused crate dependencies Found by `cargo udeps`. Unfortunately there were false positives too. * one on workspace level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by
cargo udeps. Unfortunately there were false positives too (#9881 (comment)).