Skip to content

Remove unused crate dependencies#14827

Merged
xudong963 merged 3 commits intoapache:mainfrom
findepi:findepi/remove-unused-crate-dependencies-5b2d92
Feb 23, 2025
Merged

Remove unused crate dependencies#14827
xudong963 merged 3 commits intoapache:mainfrom
findepi:findepi/remove-unused-crate-dependencies-5b2d92

Conversation

@findepi
Copy link
Member

@findepi findepi commented Feb 22, 2025

Found by cargo udeps. Unfortunately there were false positives too (#9881 (comment)).

Allow contributors to run extended tests workflow if they wish to, just
like they can run rust tests workflow on their forks, before opening a
PR to DataFusion. GitHub allows enabling/disabling workflows in the web
UI without needing to change workflow yaml file.
Found by `cargo udeps`. Unfortunately there were false positives too.
@github-actions github-actions bot added development-process Related to development process of DataFusion optimizer Optimizer rules labels Feb 22, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @findepi for the clean up

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@xudong963 xudong963 merged commit c0b749d into apache:main Feb 23, 2025
26 checks passed
@findepi findepi deleted the findepi/remove-unused-crate-dependencies-5b2d92 branch February 24, 2025 12:37
ozankabak pushed a commit to synnada-ai/datafusion-upstream that referenced this pull request Feb 25, 2025
* Enable 'extended tests' on forks

Allow contributors to run extended tests workflow if they wish to, just
like they can run rust tests workflow on their forks, before opening a
PR to DataFusion. GitHub allows enabling/disabling workflows in the web
UI without needing to change workflow yaml file.

* Remove unused crate dependencies

Found by `cargo udeps`. Unfortunately there were false positives too.

* one on workspace level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants