Skip to content

Do not unescape backslashes in datafusion-cli #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 5 commits into from
Feb 28, 2025
Merged

Do not unescape backslashes in datafusion-cli #14844

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3c56d4
correctly treat backslash in datafusion-cli
Lordworms Feb 24, 2025
87790e3
Remove all cli unescaping
alamb Feb 25, 2025
d304cfc
remove unnessasary check
Lordworms Feb 25, 2025
a4d7a10
Merge pull request #3 from alamb/alamb/remove_escaping
Lordworms Feb 25, 2025
8c1785b
refine test
Lordworms Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions datafusion-cli/src/helper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,15 +326,6 @@ mod tests {
)?;
assert!(matches!(result, ValidationResult::Valid(None)));

// should be invalid
Copy link
Contributor Author

@Lordworms Lordworms Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this check since it would throw error later
image

let result = readline_direct(
Cursor::new(
r"create external table test stored as csv location 'data.csv' options ('format.delimiter' '\u{07}');"
Copy link
Member

@findepi findepi Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth keeping this test case?

Copy link
Contributor Author

@Lordworms Lordworms Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the check is to validate delimiter in create csv files using the unescape function. It will be verified when the external table is created later.

.as_bytes()),
&validator,
)?;
assert!(matches!(result, ValidationResult::Invalid(Some(_))));

let result = readline_direct(
Cursor::new(
r"select '\', '\\', '\\\\\', 'dsdsds\\\\', '\t', '\0', '\n';".as_bytes(),
Expand Down
Loading