Skip to content

Conversation

@adamreeve
Copy link
Contributor

#17014 changed the generated documentation file rather than the source used to generate the documentation, which has caused the "check configs.md and ***_functions.md is up-to-date" CI check to start failing.

This fixes the source example to remove the extra #

@github-actions github-actions bot added the functions Changes to functions implementation label Aug 4, 2025
@adamreeve
Copy link
Contributor Author

Should we also un-ignore the docs path in CI?

Or maybe split out the docs check to another workflow.

@2010YOUY01
Copy link
Contributor

Should we also un-ignore the docs path in CI?

Or maybe split out the docs check to another workflow.

I think using another workflow for doc changes (and don't skip CI check "check configs.md and ***_functions.md is up-to-date") is a good idea.

Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Let's merge it to fix the CI failures.

@2010YOUY01 2010YOUY01 merged commit 66d6995 into apache:main Aug 4, 2025
27 checks passed
@adamreeve adamreeve deleted the window-doc-fix branch August 4, 2025 04:37
Standing-Man pushed a commit to Standing-Man/datafusion that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants