Skip to content

Refactor: Do not silently ignore errors in stats_projection #17154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Refactor: Do not silently ignore errors in stats_projection #17154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions datafusion/physical-plan/src/projection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,11 @@ impl ExecutionPlan for ProjectionExec {

fn partition_statistics(&self, partition: Option<usize>) -> Result<Statistics> {
let input_stats = self.input.partition_statistics(partition)?;
Ok(stats_projection(
stats_projection(
input_stats,
self.expr.iter().map(|(e, _)| Arc::clone(e)),
Arc::clone(&self.input.schema()),
))
)
}

fn supports_limit_pushdown(&self) -> bool {
Expand Down Expand Up @@ -279,7 +279,7 @@ fn stats_projection(
mut stats: Statistics,
exprs: impl Iterator<Item = Arc<dyn PhysicalExpr>>,
schema: SchemaRef,
) -> Statistics {
) -> Result<Statistics> {
let mut primitive_row_size = 0;
let mut primitive_row_size_possible = true;
let mut column_statistics = vec![];
Expand All @@ -292,11 +292,10 @@ fn stats_projection(
ColumnStatistics::new_unknown()
};
column_statistics.push(col_stats);
if let Ok(data_type) = expr.data_type(&schema) {
if let Some(value) = data_type.primitive_width() {
primitive_row_size += value;
continue;
}
let data_type = expr.data_type(&schema)?;
if let Some(value) = data_type.primitive_width() {
primitive_row_size += value;
continue;
}
primitive_row_size_possible = false;
}
Expand All @@ -306,7 +305,7 @@ fn stats_projection(
Precision::Exact(primitive_row_size).multiply(&stats.num_rows);
}
stats.column_statistics = column_statistics;
stats
Ok(stats)
}

impl ProjectionStream {
Expand Down Expand Up @@ -1171,7 +1170,8 @@ mod tests {
Arc::new(Column::new("col0", 0)),
];

let result = stats_projection(source, exprs.into_iter(), Arc::new(schema));
let result =
stats_projection(source, exprs.into_iter(), Arc::new(schema)).unwrap();

let expected = Statistics {
num_rows: Precision::Exact(5),
Expand Down Expand Up @@ -1207,7 +1207,8 @@ mod tests {
Arc::new(Column::new("col0", 0)),
];

let result = stats_projection(source, exprs.into_iter(), Arc::new(schema));
let result =
stats_projection(source, exprs.into_iter(), Arc::new(schema)).unwrap();

let expected = Statistics {
num_rows: Precision::Exact(5),
Expand Down