Split up monster test_window_partial_constant_and_set_monotonicity into smaller functions #17952
+1,724
−1,208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/split_up_enforce_sorting
branch
from
8d1f211 to
6b1bdc3
Compare
alamb
commented
Oct 10, 2025
| // aal here | ||
|
|
||
| #[tokio::test] | ||
| async fn test_window_partial_constant_and_set_monotonicity() -> Result<()> { |
There was a problem hiding this comment.
this was simply moved to a new module
alamb
commented
Oct 10, 2025
| use insta::assert_snapshot; | ||
| use std::sync::{Arc, LazyLock}; | ||
|
|
||
| // Function definition - Alias of the resulting column - Arguments of the function |
There was a problem hiding this comment.
I rewrote the harness to be a proper structure rather than macro, and then carefully ported each test
with the help of copilot magic auto complete.
I did not let copilot stick in the expected plan output -- instead I used the pre-existing plan output
1 task
alamb
force-pushed
the
alamb/split_up_enforce_sorting
branch
from
dc624c6 to
8267fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
test_window_partial_constant_and_set_monotonicityfrom enforce_sorting #17903Rationale for this change
I am working on the arrow 57 upgrade and I found I had to update the output of
many tests. I broke some of the changes out into their own PR for easier review
This one in particular breaks the 1200+ line test
test_window_partial_constant_and_set_monotonicity, including the 63 test cases in into individual tests so they are easier to update.Without this change, updating the 63 tests requires running the following commands in a loop (63 times):
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?