Skip to content

Conversation

@Nachiket-Roy
Copy link
Contributor

Which issue does this PR close?

N/A

Rationale for this change

A legacy inline insta snapshot was using an outdated format that does not start and end with a newline. Newer versions of insta warn about this format and will fail to match such snapshots in the future. Updating the snapshot to the modern multiline format ensures forward compatibility and avoids future snapshot failures.

What changes are included in this PR?

  • Converted a legacy inline insta snapshot to the modern multiline raw snapshot format.
  • Added leading and trailing newlines as required by current insta snapshot conventions.
  • No changes were made to the underlying logic or behavior.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the sql SQL Planner label Dec 27, 2025
@Jefffrey Jefffrey added this pull request to the merge queue Dec 28, 2025
Merged via the queue into apache:main with commit d20c5d6 Dec 28, 2025
28 checks passed
@Jefffrey
Copy link
Contributor

Thanks @Nachiket-Roy

@Nachiket-Roy Nachiket-Roy deleted the fix/snapshot-formatting branch December 28, 2025 10:13
@Nachiket-Roy
Copy link
Contributor Author

Nachiket-Roy commented Jan 12, 2026

@Jefffrey sorry for the ping but I wanted to ask who would be the right person to request reviews from for my recent PRs :
#19751 #19695 (this two are related) and #19633
edit : I’ve received some reviews already, but I may need additional reviews from someone with the right permissions or deeper familiarity with this part of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants