Skip to content

fix(functions): Make translate function postgres compatible #19630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefffrey merged 4 commits into from
Jan 6, 2026
+19 −6
Merged

fix(functions): Make translate function postgres compatible #19630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87194d8
Make translate function postgres compatible
Jan 4, 2026
e2c3643
Update SLT tests to match the new logic
Jan 4, 2026
07955ce
Merge branch 'main' into make_translate_postgres_compatible
devanshu0987 Jan 4, 2026
63102b7
Merge branch 'main' into make_translate_postgres_compatible
devanshu0987 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion datafusion/functions/src/unicode/translate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ where
// Build from_map using reusable buffer
from_graphemes.extend(from.graphemes(true));
for (index, c) in from_graphemes.iter().enumerate() {
from_map.insert(*c, index);
// Ignore characters that already exist in from_map, else insert
from_map.entry(*c).or_insert(index);
}

// Build to_graphemes
Expand Down Expand Up @@ -259,6 +260,18 @@ mod tests {
Utf8,
StringArray
);
test_function!(
TranslateFunc::new(),
vec![
ColumnarValue::Scalar(ScalarValue::from("abcabc")),
ColumnarValue::Scalar(ScalarValue::from("aa")),
ColumnarValue::Scalar(ScalarValue::from("de"))
],
Ok(Some("dbcdbc")),
&str,
Utf8,
StringArray
);
test_function!(
TranslateFunc::new(),
vec![
Expand Down
10 changes: 5 additions & 5 deletions datafusion/sqllogictest/test_files/string/string_query.slt.part
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ FROM test_basic_operator;
Andrew
Xiangpeng
Raphael
under_scrre
under_scare
percent
(empty)
(empty)
Expand All @@ -542,10 +542,10 @@ SELECT
TRANSLATE(unicode_1, 'foo', 'bar') as c
FROM test_basic_operator;
----
databusirn📊🔥
databusirn数据融合
databusirnДатаФусион
un iść crre
databusian📊🔥
databusian数据融合
databusianДатаФусион
un iść care
pan Tadeusz ma iść w kąt
(empty)
(empty)
Expand Down