Skip to content

Remove dependency on rust_decimal, remove ignore of RUSTSEC-2026-0001 #19666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 7 commits into from
Jan 7, 2026
Merged

Remove dependency on rust_decimal, remove ignore of RUSTSEC-2026-0001 #19666

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a738076
Remove dependency on rust_decimal
alamb Jan 6, 2026
1f009a9
Remove RUSTSEC-2026-0001 ignore
alamb Jan 6, 2026
330a567
fmt
alamb Jan 6, 2026
4cb7908
remove unused dep
alamb Jan 6, 2026
c3660fc
Add additional comments explaining double query execution
alamb Jan 7, 2026
9c6be08
Merge remote-tracking branch 'apache/main' into alamb/remove_rust_dec…
alamb Jan 7, 2026
406ef44
Fix Cargo.lock
alamb Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
with:
tool: cargo-audit
- name: Run audit check
# RUSTSEC-2026-0001: https://rustsec.org/advisories/RUSTSEC-2026-0001.html
# underlying rkyv is patched, but rustsec database not yet updated
# Can remove when this is merged: https://github.com/rustsec/advisory-db/pull/2565
run: cargo audit --ignore RUSTSEC-2026-0001
# Note: you can ignore specific RUSTSEC issues using the `--ignore` flag ,for example:
Copy link
Contributor Author

@alamb alamb Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added in #19657, but unecessary as this PR removes the dependency on rkyv

# run: cargo audit --ignore RUSTSEC-2026-0001
run: cargo audit
198 changes: 9 additions & 189 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion datafusion/sqllogictest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ log = { workspace = true }
object_store = { workspace = true }
postgres-protocol = { version = "0.6.7", optional = true }
postgres-types = { version = "0.2.11", features = ["derive", "with-chrono-0_4"], optional = true }
rust_decimal = { version = "1.39.0", features = ["tokio-pg"] }
# When updating the following dependency verify that sqlite test file regeneration works correctly
# by running the regenerate_sqlite_files.sh script.
sqllogictest = "0.28.4"
Expand Down
Loading
Loading