Skip to content

fix: allow Binary type coercion in split_part function #19819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lemorage wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −3
Open

fix: allow Binary type coercion in split_part function #19819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions datafusion/functions/src/string/split_part.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ use arrow::array::{AsArray, GenericStringBuilder};
use arrow::datatypes::DataType;
use datafusion_common::ScalarValue;
use datafusion_common::cast::as_int64_array;
use datafusion_common::types::{NativeType, logical_int64, logical_string};
use datafusion_common::types::{
NativeType, logical_binary, logical_int64, logical_string,
};
use datafusion_common::{DataFusionError, Result, exec_datafusion_err, exec_err};
use datafusion_expr::{
Coercion, ColumnarValue, Documentation, TypeSignatureClass, Volatility,
Expand Down Expand Up @@ -66,8 +68,16 @@ impl SplitPartFunc {
Self {
signature: Signature::coercible(
vec![
Coercion::new_exact(TypeSignatureClass::Native(logical_string())),
Coercion::new_exact(TypeSignatureClass::Native(logical_string())),
Coercion::new_implicit(
TypeSignatureClass::Native(logical_string()),
vec![TypeSignatureClass::Native(logical_binary())],
NativeType::String,
),
Coercion::new_implicit(
TypeSignatureClass::Native(logical_string()),
vec![TypeSignatureClass::Native(logical_binary())],
NativeType::String,
),
Coercion::new_implicit(
TypeSignatureClass::Native(logical_int64()),
vec![TypeSignatureClass::Integer],
Expand Down
24 changes: 24 additions & 0 deletions datafusion/sqllogictest/test_files/binary.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,3 +311,27 @@ Foo foo Foo foo
NULL NULL NULL NULL
Bar Bar Bar Bar
FooBar fooBar FooBar fooBar

# implicit coercion from Binary to String
query TTT
SELECT
cast(binary as varchar) as str,
split_part(binary, 'o', 2) as binary_split,
split_part(largebinary, 'o', 2) as large_binary_split
from t;
----
Foo (empty) (empty)
NULL NULL NULL
Bar (empty) (empty)
FooBar (empty) (empty)

query T
SELECT split_part('abc~@~def~@~ghi', arrow_cast('~@~', 'Binary'), 2);
----
def

# Reproducer for https://github.com/apache/datafusion/issues/19809
query T
SELECT split_part(split_part(arrow_cast('page.html?resolution=1920&more', 'Binary'), 'resolution=', 2), '&', 1);
----
1920