perf: Optimize array_concat using MutableArrayData#20620
Open
neilconway wants to merge 4 commits intoapache:mainfrom
Open
perf: Optimize array_concat using MutableArrayData#20620neilconway wants to merge 4 commits intoapache:mainfrom
array_concat using MutableArrayData#20620neilconway wants to merge 4 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Benchmarks: |
comphead
reviewed
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_concatto useMutableArrayData#20619 .Rationale for this change
The current implementation of
array_concatcreates anArrayReffor each row, uses Arrow'sconcatkernel to merge the elements together, and then usesconcatagain to produce the final results. This does a lot of unnecessary allocation and copying.Instead, we can use
MutableArrayData::extendto copy element ranges in bulk, which avoids much of this intermediate copying and allocation. This approach is 5-15x faster on a microbenchmark.What changes are included in this PR?
array_concatAre these changes tested?
Yes, and benchmarked.
Are there any user-facing changes?
No.