Support non-UTF-8 encoded CSV files#20626
Open
Rafferty97 wants to merge 11 commits intoapache:mainfrom
Open
Conversation
github-actions
bot
added
core
github-actions
bot
added
the
documentation
Rafferty97
force-pushed
the
non-utf8-csv2
branch
from
5beaa32 to
f1f9c5f
Compare
Rafferty97
force-pushed
the
non-utf8-csv2
branch
from
b027dda to
695f68b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #20473
Rationale for this change
CSV is a ubiquitous file format, and many are encoded in Windows-1252 and other encodings. It would be useful to have the option to read them in datafusion.
What changes are included in this PR?
encoding_rsto do the actual decodingCsvSourcesomewhat to aid the implementationDecoderDeserializer::digestas it was misleading (call sites were ignoring it)Are these changes tested?
I have added one unit test that attempts to read a SHIFT-JIS encoded CSV file. More tests are probably needed, but I may need some guidance on this. I'm also running into issues getting the test suite to run locally on my Windows machine.
Are there any user-facing changes?
Adds a new field to
CsvOptions.