ci: Harden labeler workflow, remove unnecessary checkout from pull_request_target job#20637
Open
kevinjqliu wants to merge 1 commit intoapache:mainfrom
Open
Conversation
github-actions
bot
added
the
development-process
Author
|
We can do the same for 2 other datafusion related repos, https://grep.app/search?f.repo.pattern=apache%2Fdatafusion&q=pull_request_target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR removes the checkout step from the labeler workflow and keeps labeling behavior unchanged.
What changes are included in this PR?
The workflow runs on
pull_request_target, which has elevated repo context.actions/labelerdoes not require a local checkout to work withconfiguration-path; if the file is not on disk, it fetches it via the GitHub API.Removing checkout reduces attack surface and avoids exposing persisted git credentials to subsequent steps.
Are these changes tested?
Yes, tested on my forked.
I force pushed this change to my fork's
mainbranch, then open a test PR against it. The labeler github action ran successfully on my fork and labeled the PRAre there any user-facing changes?
No